Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP-Based Sources don't increment component_discarded_events_total when requests are dropped #18644

Closed
dsmith3197 opened this issue Sep 22, 2023 · 0 comments · Fixed by #18859
Closed

HTTP-Based Sources don't increment component_discarded_events_total when requests are dropped #18644

dsmith3197 opened this issue Sep 22, 2023 · 0 comments · Fixed by #18859
Labels
domain: sources Anything related to the Vector's sources type: bug A code related bug.

Comments

@dsmith3197
Copy link
Contributor

dsmith3197 commented Sep 22, 2023 •
edited
Loading

A note for the community

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Problem

If warp stops driving a request, we don't increment component_discarded_events_total. This results in a discrepancy for events in / events out for the source. This has been observed in the Datadog Agent source in particular.

This can occur when the client has a request timeout shorter than the time it takes Vector to process the request.

Configuration

No response

Version

0.32.2

Debug Output

No response

Example Data

No response

Additional Context

No response

References

#17006
@dsmith3197 dsmith3197 added the type: bug A code related bug. label Sep 22, 2023
@dsmith3197 dsmith3197 changed the title HTTP-Based Sources doesn't increment component_discarded_events_total when requests are dropped HTTP-Based Sources don't increment component_discarded_events_total when requests are dropped Sep 22, 2023
@dsmith3197 dsmith3197 mentioned this issue Sep 22, 2023
Closed
@jszwedko jszwedko added the domain: sources Anything related to the Vector's sources label Oct 5, 2023
@dsmith3197 dsmith3197 mentioned this issue Oct 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
domain: sources Anything related to the Vector's sources type: bug A code related bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(sources): emit ComponentEventsDropped when source send is cancelled vectordotdev/vector
2 participants
@jszwedko @dsmith3197