Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve LogEvent API with Into<Lookup> values. #2843

Closed
Hoverbear opened this issue Jun 17, 2020 · 4 comments
Closed

Improve LogEvent API with Into<Lookup> values. #2843

Hoverbear opened this issue Jun 17, 2020 · 4 comments
Labels
domain: data model Anything related to Vector's internal data model domain: logs Anything related to Vector's log events type: tech debt A code change that does not add user value.

Comments

@Hoverbear
Copy link
Contributor

Hoverbear commented Jun 17, 2020

Step 6 of https://github.com/timberio/vector/blob/c4707947bd876a0ff7d7aa36717ae2b32b731593/rfcs/2020-05-25-more-usable-logevents.md#sales-pitch

This step does what #2842 did not do, and cleans/refines the API.

You should try to condense functionality like insert_path and insert or remove_path and remove to use Into<Path>.

During this time, the main bulk of the work will presumably be updating component configurations to use and handle the new Lookup type so it can be properly passed to the refined insert/remove functions.

Do this at the config/definition level whenever possible. This issue entrusts you to make a distinction between user input and internal code. Turn user input into a Lookup as soon as you practically can.

Depends on #2842

@Hoverbear Hoverbear added this to the Usable Events milestone Jun 17, 2020
@binarylogic binarylogic added the type: tech debt A code change that does not add user value. label Jun 19, 2020
@binarylogic binarylogic removed this from the Usable Events milestone Jul 19, 2020
@binarylogic binarylogic added domain: data model Anything related to Vector's internal data model and removed domain: ux labels Jul 29, 2020
@binarylogic binarylogic added domain: logs Anything related to Vector's log events and removed event type: log labels Aug 6, 2020
@Hoverbear Hoverbear changed the title Improve LogEvent API with Into<Path> values. Improve LogEvent API with Into<Lookup> values. Sep 24, 2020
@Hoverbear
Copy link
Contributor Author

Putting a pin in this until 0.11, as we don't want to merge it prior, and it will just constantly merge conflict until after that.

@binarylogic
Copy link
Contributor

we don't want to merge it prior

Any reason why? Just general stability concerns?

@Hoverbear
Copy link
Contributor Author

Hoverbear commented Oct 29, 2020

Kind of, yeah! I'd prefer this this change to be part of the release remap stabilizes since they will use all the same parsing rules. This way we can say "Okay, here, in 0.12 remap and the new lookups happened so all configs which are broken just need to follow these simple few rules globally", instead of "Okay now in these particular transforms the rules are slightly different" or risking finding other inconsistencies after release and requiring a hotfix.

@jszwedko
Copy link
Member

jszwedko commented Aug 2, 2022

Closing since we ended up introducing a new implementation for lookups.

@jszwedko jszwedko closed this as completed Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: data model Anything related to Vector's internal data model domain: logs Anything related to Vector's log events type: tech debt A code change that does not add user value.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants