request.in_flight_limit alias no longer works

[jszwedko]

This appears to be a regression from 0.11.1 as it works there; we should fix before 0.12 cc/ @jamtur01 @binarylogic

Vector Version

vector 0.12.0 (gb448cf4 x86_64-unknown-linux-gnu 2021-01-07)

Vector Configuration File

[sources.in]
type = "stdin"

[sinks.company_unfurler_http]
type = "http"
inputs = ["in"]
uri = "http://example.com"
encoding.codec = "json"

[sinks.company_unfurler_http.request]
in_flight_limit = 100
rate_limit_duration_secs = 5
rate_limit_num = 60

Debug Output

➜  vector git:(master) ./target/debug/vector --config /tmp/http.toml -vvv 
Jan 07 19:51:00.598  INFO vector::app: Log level is enabled. level="vector=trace,codec=trace,file_source=trace,tower_limit=trace,rdkafka=trace"
Jan 07 19:51:00.598  INFO vector::sources::host_metrics: PROCFS_ROOT is unset. Using default '/proc' for procfs root.
Jan 07 19:51:00.598  INFO vector::sources::host_metrics: SYSFS_ROOT is unset. Using default '/sys' for sysfs root.
Jan 07 19:51:00.598  INFO vector::app: Loading configs. path=[("/tmp/http.toml", None)]
Jan 07 19:51:00.612 ERROR vector::cli: Configuration error. error=unknown field `in_flight_limit` for key `sinks.company_unfurler_http` at line 10 column 1

Expected Behavior

Vector sets the concurrency limit to 100.

Actual Behavior

Vector fails to start.

[jamtur01]

I suspect it is likely 4b94c3a.

[ktff]

Found the issue serde-rs/serde#1504. It seams we've been bitten by it several times now.

[jamtur01]

Argh - yeah - a58b819. I had forgotten that one.