Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use immutable strings in our data model #6991

Closed
blt opened this issue Apr 2, 2021 · 2 comments
Closed

Use immutable strings in our data model #6991

blt opened this issue Apr 2, 2021 · 2 comments
Assignees
Labels
domain: data model Anything related to Vector's internal data model domain: performance Anything related to Vector's performance

Comments

@blt
Copy link
Contributor

blt commented Apr 2, 2021

We know from #6831 that vector has high allocation pressure. It's basic datum -- the Event -- encodes a String in several places but does not mutate this string. We can shave at least one word from each Event by using Box<str> in these places. Resolution of this ticket will collide somewhat with #5374 but the work is complementary. This will also have bearing on #6673 as well, buying headroom if nothing else.

@blt blt added domain: data model Anything related to Vector's internal data model domain: performance Anything related to Vector's performance labels Apr 2, 2021
@blt blt self-assigned this Apr 2, 2021
@blt
Copy link
Contributor Author

blt commented Apr 12, 2021

Had some work put into this project here #6846. Ultimately closed for lack of evidence that this would effect vector performance today.

@blt
Copy link
Contributor Author

blt commented Apr 16, 2021

I'm closing this. I do not believe we can tackle this as a singular project, more a long-term goal that we'll pick at in reviews.

@blt blt closed this as completed Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: data model Anything related to Vector's internal data model domain: performance Anything related to Vector's performance
Projects
None yet
Development

No branches or pull requests

1 participant