Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore event structure before passing it to the lua runtime #706

Closed
binarylogic opened this issue Aug 4, 2019 · 0 comments · Fixed by #2095
Closed

Restore event structure before passing it to the lua runtime #706

binarylogic opened this issue Aug 4, 2019 · 0 comments · Fixed by #2095
Labels
meta: idea Anything in the idea phase. Needs further discussion and consensus before work can begin. transform: lua Anything `lua` transform related
Milestone
Improve Data Proc...

Comments

@binarylogic
Copy link
Contributor

Related #704

This raises the question of unflattening the event before providing it to the user's Lua script in the lua transform. Without this, the user must access arrays and nested items through our flattened structure. This feels a little strange given that Lua is a runtime and it can work with nested objects and arrays.

I'm not necessarily proposing changes here, but I wanted to think about it as we think through #704, and have this document our decision for posterity.
@binarylogic binarylogic added meta: idea Anything in the idea phase. Needs further discussion and consensus before work can begin. transform: lua Anything `lua` transform related labels Aug 4, 2019
@binarylogic binarylogic mentioned this issue Aug 7, 2019
Closed
@binarylogic binarylogic added this to the Improve data processing milestone Sep 17, 2019
@binarylogic binarylogic assigned ghost Dec 21, 2019
@ghost ghost mentioned this issue Jan 31, 2020
Closed
@ghost ghost mentioned this issue Mar 6, 2020
Closed
@ghost ghost mentioned this issue Mar 20, 2020
Merged
@ghost ghost closed this as completed in #2095 Mar 24, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta: idea Anything in the idea phase. Needs further discussion and consensus before work can begin. transform: lua Anything `lua` transform related
Projects
None yet
Milestone
Improve Data Processing
Development

Successfully merging a pull request may close this issue.

enhancement(lua transform): Support metric events in version 2 vectordotdev/vector
1 participant
@binarylogic