-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New timescale
sink
#939
Comments
I’m not familiar with Timescale, but wonder would it make sense support unified SQL sinks, which would include Postgres, ClickHouse, and at least for the sake of easy tests, SQLite. The idea is to have same configuration structure for them and, ideally, support some kind of automatic table creation/migrations. |
As far as writing data there is no difference between Timescale and Postgres. It would be up to the user to configure the destination tables (and hypertables in the Timscaledb case) before the sink was used. |
A general unified SQL sink might be challenging given the language variants between the different databases. But @jamessewell is correct, there should be no difference in writing data between Timescale and Postgres (but there may be other reasons for creating a Timescale specific sink). |
I forgot to note our progress here: this can be achieved using |
@jamessewell Could you please elaborate on details of your implementation of this if possible? |
Note that there is a more generic issue #6556 which should probably be implemented first. As discussed above, it might even already solve this issue. |
Repurposing this to be for |
I'd like to support Timescale as a sink, and after talking to them it appears we just need to support Postgres since Timescale is built on Postgres. I'm hesitant to call it a Postgres sink given that we'll probably want to make certain assumptions about how we're writing data. Before we begin work we should determine if this is the appropriate course of action.
Ref #935
The text was updated successfully, but these errors were encountered: