Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Meta] Item & Recipe Integration (Forge Tags) #35

Closed
vectorwing opened this issue Jul 28, 2020 · 8 comments
Closed

[Meta] Item & Recipe Integration (Forge Tags) #35

vectorwing opened this issue Jul 28, 2020 · 8 comments
Labels
help wanted Looking for contributors to help with this

Comments

@vectorwing
Copy link
Owner

I haven't fully implemented compatibility and integration on the mod's items yet, and I'm still wondering what is the best way to approach that. For example: tagging items like Rice so that other mods can use it on rice-related recipes (forge:rice?).

If anyone has resources or recommendations on how to go about this, or how other farming mods do it, please let me know here!

@vectorwing vectorwing added the help wanted Looking for contributors to help with this label Jul 28, 2020
@vectorwing
Copy link
Owner Author

Also, if anyone's savvy with it, we're open to pull requests tagging either items or recipes to be compatible with recipes/ingredients of other mods!

@WenXin20
Copy link

WenXin20 commented Jul 29, 2020

Hello, I believe Simple Farming does something similar, it uses tags by putting fruits and veggies in tags such as forge:crops/onions, forge:vegetables/onions, and forge:fruits/orange.
https://github.com/cweckerl/simplefarming/tree/1.15/src/main/resources/data/forge/tags/items

@vectorwing
Copy link
Owner Author

Hmm! SF and Pam's seem to share a lot of tags, though Pam's really covers every use case it has. I'll adopt those. Thanks for letting me know!

@vectorwing vectorwing pinned this issue Jul 29, 2020
@WenXin20
Copy link

WenXin20 commented Aug 4, 2020

Hi again!
Mulch is missing the forge:dirt tag, which means modded plants can't be placed on it or be used in recipes. Maybe the same for Organic Compost?

And if wild crops are given the minecraft:small_flowers tag, bees will pollinate them. :)

@shattyyt
Copy link

shattyyt commented Aug 4, 2020

Bees are already pollinating the crops with the recent commits, don't know about mulch though

@WenXin20
Copy link

WenXin20 commented Aug 4, 2020

Oh, I meant the wild crop plants that spawn in the world.

@vectorwing
Copy link
Owner Author

vectorwing commented Aug 4, 2020

Oh yeah, I added them to minecraft:small_flowers like you suggested! Bees are now attracted to them as blocks and can be bred with them. It's in the newest branch, feature/moar-foods. I'm checking the other tags as well, and adding some I missed (such as forge:rawfish and forge:cookedfish

@vectorwing vectorwing changed the title [Meta] Item Integration (forge tags) [Meta] Item & Recipe Integration (Forge Tags) Aug 4, 2020
@vectorwing
Copy link
Owner Author

Integration seems good for now, I'll reopen this some other time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Looking for contributors to help with this
Projects
None yet
Development

No branches or pull requests

3 participants