Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Action uses PAT owner's fork instead of fork-user input #100

Closed
1 task done
sitiom opened this issue Feb 13, 2023 · 0 comments · Fixed by russellbanks/Komac#91
Closed
1 task done

[Bug]: Action uses PAT owner's fork instead of fork-user input #100

sitiom opened this issue Feb 13, 2023 · 0 comments · Fixed by russellbanks/Komac#91
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@sitiom
Copy link
Contributor

sitiom commented Feb 13, 2023 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

See https://github.com/localsend/localsend/actions/runs/4162356577/jobs/7201427695
image
Additionally, the action tries to find the main branch when it doesn't exist, and the default branch is master. It also silently returns with success (when it shouldn't).
@sitiom sitiom added bug Something isn't working help wanted Extra attention is needed labels Feb 13, 2023
@sitiom sitiom mentioned this issue Feb 13, 2023
Merged
@vedantmgoyal9 vedantmgoyal9 changed the title [Bug]: Winget Releaser uses PAT owner's fork instead of default ${{ github.repository_owner }} [Bug]: Winget Releaser uses PAT owner's fork instead of fork-user input Feb 13, 2023
@vedantmgoyal9 vedantmgoyal9 mentioned this issue Feb 13, 2023
Merged
@vedantmgoyal9 vedantmgoyal9 changed the title [Bug]: Winget Releaser uses PAT owner's fork instead of fork-user input [Bug]: Action uses PAT owner's fork instead of fork-user input Feb 13, 2023
@vedantmgoyal9 vedantmgoyal9 removed their assignment Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add environment variable to override fork owner
2 participants
@sitiom @vedantmgoyal9