Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/Idea]: Make action run cross-platform #126

Closed
sitiom opened this issue Mar 21, 2023 · 7 comments · Fixed by #168
Closed

[Feature/Idea]: Make action run cross-platform #126

sitiom opened this issue Mar 21, 2023 · 7 comments · Fixed by #168
Labels
feat New feature request

Comments

@sitiom
Copy link
Contributor

sitiom commented Mar 21, 2023

What would you like to see changed/added?

Komac is already cross-platform. The only thing that needs to be added in non-Windows platforms is proper MSI detection, as stated in russellbanks/Komac#110.

Other than that, it works well. This would enable Winget Releaser to immediately run in a current deploy job (most likely ubuntu-latest) instead of having to separate it. I also think that ubuntu-latest runners have a shorter startup time than windows-latest; it would help for a shorter workflow run time.

@sitiom sitiom added the feat New feature request label Mar 21, 2023
@vedantmgoyal9
Copy link
Owner

I will wait until @russellbanks has fixed russellbanks/Komac#110, because I don't want incorrect manifests created through my action. Although, nothing much is needed to do here except to update the docs and remove the condition: https://github.com/vedantmgoyal2009/winget-releaser/blob/227c8615e56c29da23d1da19206844bccb698b29/main.ts#L10-L13 so that can be done anytime once issues are fixed in Komac itself.

@russellbanks
Copy link
Contributor

MSI support on non-windows platforms was added in 1.4.0 of Komac. The lack of a token storage implementation on other platforms than Windows doesn't matter as WinGet Releaser always provides a token to Komac so the token never needs to be stored anywhere.

@vedantmgoyal9 vedantmgoyal9 removed their assignment May 11, 2023
@sitiom
Copy link
Contributor Author

sitiom commented May 11, 2023

Gonna have to update the readme too (and maybe some testing to see if it works fine?)

@vedantmgoyal9
Copy link
Owner

I've already updated however if something is left, you can always open a PR. @russellbanks it's time to test Komac on Linux platforms 😁🥳

@sitiom
Copy link
Contributor Author

sitiom commented Jun 4, 2023

I've already updated however if something is left, you can always open a PR.

@sitiom
Copy link
Contributor Author

sitiom commented Jun 5, 2023

Works (except for the other unfixed bug in #167):

@vedantmgoyal9
Copy link
Owner

@sitiom If you are updating all workflows to use Linux runner, according to russellbanks/Komac#110 (comment), I would advise not to change if that repository has an MSI installer. It might generate incorrect manifests in some cases. Windows would be still the preferred choice.

@vedantmgoyal9 vedantmgoyal9 linked a pull request Jun 5, 2023 that will close this issue
Repository owner locked as resolved and limited conversation to collaborators Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feat New feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants