-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature/Idea]: Make action run cross-platform #126
Comments
I will wait until @russellbanks has fixed russellbanks/Komac#110, because I don't want incorrect manifests created through my action. Although, nothing much is needed to do here except to update the docs and remove the condition: https://github.com/vedantmgoyal2009/winget-releaser/blob/227c8615e56c29da23d1da19206844bccb698b29/main.ts#L10-L13 so that can be done anytime once issues are fixed in Komac itself. |
MSI support on non-windows platforms was added in 1.4.0 of Komac. The lack of a token storage implementation on other platforms than Windows doesn't matter as WinGet Releaser always provides a token to Komac so the token never needs to be stored anywhere. |
Gonna have to update the readme too (and maybe some testing to see if it works fine?) |
I've already updated however if something is left, you can always open a PR. @russellbanks it's time to test Komac on Linux platforms 😁🥳 |
|
Works (except for the other unfixed bug in #167): |
@sitiom If you are updating all workflows to use Linux runner, according to russellbanks/Komac#110 (comment), I would advise not to change if that repository has an MSI installer. It might generate incorrect manifests in some cases. Windows would be still the preferred choice. |
What would you like to see changed/added?
Komac is already cross-platform. The only thing that needs to be added in non-Windows platforms is proper MSI detection, as stated in russellbanks/Komac#110.
Other than that, it works well. This would enable Winget Releaser to immediately run in a current deploy job (most likely
ubuntu-latest
) instead of having to separate it. I also think thatubuntu-latest
runners have a shorter startup time thanwindows-latest
; it would help for a shorter workflow run time.The text was updated successfully, but these errors were encountered: