Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback/Impressions while implementing for gsudo. #47

Closed
gerardog opened this issue Oct 19, 2022 · 4 comments
Closed

Feedback/Impressions while implementing for gsudo. #47

gerardog opened this issue Oct 19, 2022 · 4 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation help wanted Extra attention is needed

Comments

@gerardog
Copy link
Contributor

What would you like to see changed/added?

Follow up to gerardog/gsudo#189, trying to use WinGet-Releaser

  • The bot retrieves ProductCode successfully for gsudo. How do I achieve the same with winget-releaser?
  • Is there a test-mode? a way to run the releaser, make it commit on my fork, but not create the pull request to microsoft yet?
  • How do I customize the output json? for example, Architecture: "neutral"
@vedantmgoyal9
Copy link
Owner

vedantmgoyal9 commented Oct 20, 2022

  • The bot retrieves ProductCode successfully for gsudo. How do I achieve the same with winget-releaser?

The ProductCode will be automatically found by the action.

  • Is there a test-mode? a way to run the releaser, make it commit on my fork, but not create the pull request to microsoft yet?

You can use https://bittu.eu.org/docs/wr-playground/. BTW, there isn't any testing mode (dry-run) in the action itself.

  • How do I customize the output json? for example, Architecture: "neutral"

You need to do that manually, the action updates version, installer urls, release date, release notes url and other installer related fields like installer hash, product code, etc...

@gerardog
Copy link
Contributor Author

gerardog commented Oct 21, 2022

I see @vedantmgoyal2009... Please add a dry-run, that wont create the pull request to msft.

Other issues I faced:

  remote: Permission to gerardog/winget-pkgs.git denied to gerardog.
  fatal: unable to access 'https://github.com/gerardog/winget-pkgs.git/': The requested URL returned error: 403
  HTTP 401: Personal access tokens with fine grained access do not support the GraphQL API (https://api.github.com/graphql)
  Try authenticating with:  gh auth login

Problem with permissions, I will fix them. but action completed as Success, not fail.

@gerardog
Copy link
Contributor Author

gerardog commented Oct 21, 2022

Permissions problem solved.

Now, 2 issues:

@gerardog gerardog changed the title [Feature/Idea]: WIX Installer ProductCode Feedback/Impressions while implementing for gsudo. Oct 21, 2022
@vedantmgoyal9
Copy link
Owner

  • The manifest says .msi Architecture is x64. I need to override this with neutral. The .msi is actually an x86 setup with a condition to deploy either x86 or x64 binaries.

@vedantmgoyal9 vedantmgoyal9 added bug Something isn't working documentation Improvements or additions to documentation help wanted Extra attention is needed and removed feat New feature request labels Oct 28, 2022
@vedantmgoyal9 vedantmgoyal9 removed their assignment Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants