Parameter for wallet password is inconsistent with other vegacapsule passwords.

[daniel1302]

We have the following config in the vegacapsule:

 node_set "validators" {
    count = 13
    mode = "validator"

    visor_binary = "visor"
    node_wallet_pass = "n0d3w4ll3t-p4ssphr4e3"
    vega_wallet_pass = "w4ll3t-p4ssphr4e3"
    ethereum_wallet_pass = "ch41nw4ll3t-3th3r3um-p4ssphr4e3"

    config_templates {
      vega_file = "./net_configs/mainnet/vega.tmpl"
      tendermint_file = "./net_configs/mainnet/tendermint.tmpl"

  	  visor_run_conf_file = "./net_configs/mainnet/visor_run.tmpl"
      visor_conf_file = "./net_configs/mainnet/visor_config.tmpl"
    }
  }

You can see we provide passwords in plain text. Then vegacapsule manage files for that password.

Issue

For some reason, we have chosen the password for vega-wallet to be an existing file.

  wallet "wallet-1" {
    token_passphrase_path = "${network_home_path}/../api-token-passphrase-file"

Now people cannot start networking with vegacapsule bootstrap..., they first need to correct paths to file or have exactly the same dir structure as someone who designed vegacapsule config.

disadvantages

• File must exist before the network is initialized.
• You have to provide one of :
  • relative path to the place where are you calling vegacapsule from
  • absolute path
• both paths are very bad because they cannot be the same for most of the scenarios(different systems, different workspaces, etc.)

Solution

1. Allow providing plain text password for the wallet
2. If a password is provided, vegacapsule needs to create a password file and manage it