Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make planets and stations invulnerable #1048

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

royfalk
Copy link
Contributor

@royfalk royfalk commented Feb 28, 2025

Closes #1018

Code Changes:

Copy link

@kheckwrecker kheckwrecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Banged on Serenity as long as I could (before I got shot out of the sky) and could not detect any damage done to the base, so I'd say from a playtesting perspective, this PR is good to merge.

@kheckwrecker kheckwrecker self-requested a review February 28, 2025 23:28
@stephengtuggy
Copy link
Contributor

I do not think stations should be invulnerable. Planets? Maybe. Stations? Not so much.

@royfalk
Copy link
Contributor Author

royfalk commented Mar 1, 2025

I do not think stations should be invulnerable. Planets? Maybe. Stations? Not so much.

I don't have a firm opinion on this. However, lacking support for saving the death of a station in the save file means it comes back to life when you load the game.

The issue has a discussion of this, including the obligatory issues with Skyrim characters dying and certain storylines getting trimmed.

For now, units loaded from star system are invulnerable. We can revisit this after we fix the bugs.

@kheckwrecker
Copy link

I do not think stations should be invulnerable. Planets? Maybe. Stations? Not so much.

I have to agree with royfalk's comments. Someday in the future development, it would be wonderful to have the need and ability to destroy a station to advance a campaign storyline. That would make for an amazing and awesomely deep story line. The only problem right now with the game engine, is that as soon as you save your game and reload, the destroyed station reappears. I can only imagine how much programming would go into making sure destroyed stations stayed destroyed in saved games. As much as I personally would like to see a fully destructible environment, I'm guessing it's not likely to happen for a while?

@kheckwrecker
Copy link

An update to my earlier review - I was documenting some of my findings with docking, and was flying a routine patrol mission to Phillies ( a planet in Cephid-17 system), and I was almost within the distance to have the docking countdown show up (approx. 260,000 km away - see my comments under the docking PR) when Phillies blew up right in front of me. I'm running a version of master with PR's 1036, 1039, 1047 and 1048 cherry-picked and merged.

It looks like the problem of planets blowing up is not resolved after all.

@royfalk
Copy link
Contributor Author

royfalk commented Mar 2, 2025

I think the auto-destroy logic destroyed it.
I don't know what it is or what else to call it.
It's the process that shows ships being destroyed in the top left text screen.
I don't know if the ships there are real or not and what's causing them to be destroyed.
It may be in the assets/python scripts.

@kheckwrecker
Copy link

To clarify my last comment. I am still experiencing planets disappearing, and I have merged this PR into my clone of master. I had two more (Broadway and Phillies) disappear tonight while flying around testing docking distances.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Planets sustain damage
3 participants