Auto Self Destruct not working as expected

[kheckwrecker]

When in space, if I hit the ! (Shift+1), all my weapons in my HUD turn red, but the rest of my ship remains intact. I can fly around and even land. If I hit ! again while approaching a planet the self-destruct will work, but I'm pretty sure it's supposed to work as soon as I hit ! at any time in space.

[royfalk]

What branches (engine/assets) are you running?
Also, what ship?

I also tried Vigilance (one time) in master/master and the ship was destroyed but I auto-ejected.
I just tried both Vigilance and Llama.begin in branches task_armor_2 (engine)/task_armor (assets) several times and it works fine.

@BenjamenMeyer , @stephengtuggy , @evertvorster - what do you think is the right behavior. Should auto-eject be applied here? Auto-eject typically applies x% of the time. I'm not sure if this is the case here or if I changed something in #1016.

[kheckwrecker]

I was playing master/master with a dostoevsky.

My opinion is that auto-destruct should completely destroy your ship and give you the option of re-loading or quitting.

[stephengtuggy]

It only self-destructs a certain percentage of the time. It’s been that way for a while now, probably at least a year. This is not the correct behavior though. Auto Self Destruct should always completely destroy ship, pilot, and pilot pod, and take you to the Grim Reaper screen where you can either respawn or quit. This expected behavior is more or less implied by the name of the keyboard function (“Auto Self Destruct”).

It would be nice to get this fixed finally.

[kheckwrecker]

Auto Self Destruct should always completely destroy ship, pilot, and pilot pod, and take you to the Grim Reaper screen where you can either respawn or quit. This expected behavior is more or less implied by the name of the keyboard function (“Auto Self Destruct”).

I agree, and I also think (even though it's not a bug) that the way "quit" works should change. I did start a Discussion on it, since it's not a bug, but rather a request for change (sometime down the road).

[BenjamenMeyer]

I'll agree with @stephengtuggy on the fix.