Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Jumping - 0.9.x #1035

Draft
wants to merge 8 commits into
base: 0.9.x
Choose a base branch
from

Conversation

stephengtuggy
Copy link
Contributor

Code Changes:

Issues:

Purpose:

  • What is this pull request trying to do? Fix jumping, and possibly SPEC mode as well, for 0.9.x
  • What release is this for? 0.9.x
  • Is there a project or milestone we should apply this to? 0.9.x

@stephengtuggy stephengtuggy added this to the 0.9.x milestone Feb 16, 2025
@stephengtuggy stephengtuggy self-assigned this Feb 16, 2025
Copy link
Contributor

@royfalk royfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just reviewed the SPEC commit. LGTM.

@BenjamenMeyer
Copy link
Member

@stephengtuggy this is on top of #1030?

@kheckwrecker
Copy link

Merged this PR and PR#1030 on top of the 0.9x engine source. Game compiled fine. Launched new game, bought a jump drive and an overdrive, selected a cargo mission and jumped to Everett. Jump went fine but used a lot of energy. Unfortunately, game crashed soon after jumping. Restarted game (in debugger), loaded saved game, accepted another cargo run to Everett and launched into space. Now I have JUMP: LOW ENERGY on the screen, and when I fly to a jump point, I'm unable to jump.

@stephengtuggy
Copy link
Contributor Author

@stephengtuggy this is on top of #1030?

@BenjamenMeyer yes, it is.

@stephengtuggy
Copy link
Contributor Author

Merged this PR and PR#1030 on top of the 0.9x engine source. Game compiled fine. Launched new game, bought a jump drive and an overdrive, selected a cargo mission and jumped to Everett. Jump went fine but used a lot of energy. Unfortunately, game crashed soon after jumping. Restarted game (in debugger), loaded saved game, accepted another cargo run to Everett and launched into space. Now I have JUMP: LOW ENERGY on the screen, and when I fly to a jump point, I'm unable to jump.

@kheckwrecker I am seeing pretty much the same thing. When loading a saved game, I no longer have enough FTL capacitance to jump. More work is needed.

@BenjamenMeyer
Copy link
Member

@stephengtuggy this is on top of #1030?

@BenjamenMeyer yes, it is.

Okay...thanks. I'll wait to review this until #1030 is merged and this reflects that.

@royfalk
Copy link
Contributor

royfalk commented Feb 18, 2025

Please upload your saved game ship json.

@kheckwrecker
Copy link

Please upload your saved game ship json.

Here you go...
Llama.begin.csv

Except for some reason, it's CSV and not JSON?

@royfalk
Copy link
Contributor

royfalk commented Feb 19, 2025

Can you yaw? Turn right and left?
If you go into ship view in base computer, does it say you have 40,000 warp/spec capacitor?

@stephengtuggy this is almost certainly #865. It's a rather critical bug and fixed by #898. It should be pulled into 0.9.

I think we missed it because most people don't play test the Llama and it only affects this ship.

@kheckwrecker
Copy link

Can you yaw? Turn right and left?

Yes

If you go into ship view in base computer, does it say you have 40,000 warp/spec capacitor?

No. Here's what it shows:
Capture

@royfalk
Copy link
Contributor

royfalk commented Feb 20, 2025

@stephengtuggy
There's something wrong here. 166k MJ is the old number.
833MJ is just weird. Llama begin has 325 for SPEC capacitor and the inconsistent spec_capacitor02 (400MJ).
My recommendation, find out where jump cost is defined and divide by 1000.

@stephengtuggy
Copy link
Contributor Author

This is stupid. I keep trying to test and troubleshoot the jump functionality of this code, but the game crashes so often that it's almost impossible to test. My efforts basically amount to trying to put lipstick on a pig. I've had enough.

Let's get this 0.9.0 code out, FWIW, then follow up as quickly as possible with some code that actually works.

@kheckwrecker
Copy link

This is stupid. I keep trying to test and troubleshoot the jump functionality of this code, but the game crashes so often that it's almost impossible to test. My efforts basically amount to trying to put lipstick on a pig. I've had enough.

Let's get this 0.9.0 code out, FWIW, then follow up as quickly as possible with some code that actually works.

I feel your pain. My experience has been very similar when trying to test this PR. Happens so often I usually run this version in a debugger to see if anything useful shows up.

I haven't had a chance to pull your latest changes to this PR. I'll try to do that tomorrow and see if I can make a couple of jumps.

@royfalk
Copy link
Contributor

royfalk commented Feb 23, 2025

@stephengtuggy
Can you coredumpctl -1 gdb and tell me what's crashing the game?
We shouldn't release 0.9 if it's so unstable.

@kheckwrecker
Copy link

I tried to test this latest PR. Wanted a simple flight, so I bought a afterburner for my Llama and headed for Serenity. No game crashes, but the afterburner is seriously messed up. I get speeds up to 700 (when it should be more like 212), and I can't land on Serenity. Every time I approach, it actually flys away from me, even with the afterburner engaged. Also, sometimes my speed increases when I disengage afterburner, and sometimes in decreases when I engage afterburner. Never got closer than 3,000 meters and finally quit the game.

@royfalk
Copy link
Contributor

royfalk commented Feb 24, 2025

I tried to test this latest PR.

Please add your setup when writing these. I assume you started a new campaign and bought an afterburner. Given the difficulty you've had with 0.9, maybe move to something else. I'll try and take a look this week and see if I can't figure out what's going on.

@BenjamenMeyer , @stephengtuggy , can you tell me to cut-off point for 0.9?

@kheckwrecker
Copy link

I tried to test this latest PR.

Please add your setup when writing these. I assume you started a new campaign and bought an afterburner. Given the difficulty you've had with 0.9, maybe move to something else. I'll try and take a look this week and see if I can't figure out what's going on.

@BenjamenMeyer , @stephengtuggy , can you tell me to cut-off point for 0.9?

Running in Windows, from a fresh build yesterday with the latest version of PR 1035. Yes, started a new campaign, and bought a new Overdrive II. Sorry to bother you with my posts. I can move on to some other project.

@stephengtuggy
Copy link
Contributor Author

@kheckwrecker you’re not bothering us at all. This is extremely valuable information to get from a user’s perspective.

The autopilot turning away at a certain distance from the target is another known issue. When it happens, I just turn off the autopilot and fly the rest of the way to the target manually. It’s not ideal, but it works.

@stephengtuggy
Copy link
Contributor Author

@royfalk I know where the crash is occurring. It’s in Mesh::loadExistant(Mesh &)

@stephengtuggy
Copy link
Contributor Author

I just haven’t figured out how to fix it yet

@BenjamenMeyer
Copy link
Member

I tried to test this latest PR.

Please add your setup when writing these. I assume you started a new campaign and bought an afterburner. Given the difficulty you've had with 0.9, maybe move to something else. I'll try and take a look this week and see if I can't figure out what's going on.

@BenjamenMeyer , @stephengtuggy , can you tell me to cut-off point for 0.9?

https://github.com/vegastrike/Vega-Strike-Engine-Source/network provides good insight there.

This seems to be the commit where we split of the 0.9.x branch at:
adc6284
Looks like part of #796.

Everything else seems to be:

  • fixes for GitHub Action
  • Installer work
  • Licensing
  • Pulling up some stuff that seemed to get applied only to 0.8.x so we lost it for 0.9.x and master (program options)
  • Fixing the Python version stuff (eval.h)

IIRC there was some pretty significant changes about to happen to master (0.10.x) after #796 which is why we cut it there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.9.x now takes a lot of SPEC/FTL capacitors to provide enough energy to jump
4 participants