Prevent integral duplicates (#1038) #1047
Conversation
Hide sell button for integral
royfalk
requested review from
BenjamenMeyer,
evertvorster,
stephengtuggy and
kheckwrecker
|
Just curious, does that "integral" thing means "integrated", as in part of the ship design itself, fixed and cannot be removed ? Another question, why does |
I actually checked before. I was looking for a word that would indicate it cannot be removed. Integral fit better.
Possibly. We are in the process of refactoring legacy code and the original devs are not around to ask. I did see that it seemed redundant somehow but the whole flow is destined for removal soon anyhow. |
| @@ -3161,6 +3161,13 @@ bool Unit::UpAndDownGrade(const Unit *up, | |||
| bool Unit::ReduceToTemplate() { | |||
| vector<Cargo> savedCargo; | |||
| savedCargo.swap(cargo); | |||
|
|
|||
| // Remove integral components, because they become duplicates | |||
| savedCargo.erase(std::remove_if(savedCargo.begin(), | |||
There was a problem hiding this comment.
Has this been carefully tested? It looks like it might be correct, but historically, we have had some issues with deleting items from collections. So better safe than sorry, it seems to me
There was a problem hiding this comment.
I debugged this and placed breakpoints to assure myself it does exactly what I think it does.
In case you're wondering, I went through several iterations of touching the code and realizing that it doesn't solve the problem.
I'm fairly confident of this solution. However, it should go away when we finish migrating to libcomponent.
|
@royfalk thanks for the explanations |
Also hide sell button for integral
Thank you for submitting a pull request and becoming a contributor to the Vega Strike Core Engine.
Please answer the following:
Code Changes:
Fixes #1038