Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor vegastrike-engine and vegasettings to use boost::program_options -- 0.10.x #999

Merged
merged 6 commits into from
Jan 18, 2025
Merged

Refactor vegastrike-engine and vegasettings to use boost::program_options -- 0.10.x #999

merged 6 commits into from
Jan 18, 2025
+250 −218

Conversation

stephengtuggy
Copy link
Contributor

Code Changes:

Issues Addressed:

Purpose:

  • What is this pull request trying to do? Implement the boost::program_options refactor for the last time, hopefully, this time for 0.10.x / the 'master' branch
  • What release is this for? 0.10.x
  • Is there a project or milestone we should apply this to? 0.10.x

@stephengtuggy
setup.cpp: Switch to boost::program_options for parsing command line …
cf6ef81 
…parameters
@stephengtuggy
CMakeLists.txt x3: Change MESSAGE("++ ...") to MESSAGE(STATUS "...")
3a4976c
@stephengtuggy
CMakeLists.txt x4: Change MESSAGE("-- ...") to `MESSAGE(STATUS "...…
a4abba0 
…")`, and `MESSAGE("!! ...")` TO `MESSAGE(WARNING "...")`. engine/CMakeLists.txt, engine/src/main.cpp: Additionally, switch Vega Strike itself over to boost::program_options.
@stephengtuggy stephengtuggy added this to the 0.10.x milestone Jan 18, 2025
@stephengtuggy stephengtuggy self-assigned this Jan 18, 2025
royfalk
royfalk approved these changes Jan 18, 2025
View reviewed changes
Copy link
Contributor

@royfalk royfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to be more aggressive in your changes (without breaking stuff). The game was written 25 years ago. A lot of the code and features should go away or be rewritten from scratch.

engine/src/main.cpp Outdated
// return Audio::Test::main(argc, argv);
}

if (cmd_args.count("a")) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete all three resolutions. We shouldn't support anything under 1920x1080.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree about not supporting anything under 1920x1080. There are times -- especially in a VM -- when running with a lower resolution is necessary.

With that said, 800x600 is ridiculously low. I think I will go ahead and remove that option.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

800x600 option deleted.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@royfalk I don't think I've ever run at 1920x1080 - that would be full screen for me. I don't think I run as small as 800x600 often.

@evertvorster
Copy link
Contributor

Just tried running this, and it fails instantly:

[evert@Evert vegastrike-engine-git]$ vs
Starting Vega Strike...

Registering codec ogg
.
Legacy Mode: TRUE
Saving current directory (/mnt/int/system/aur/vegastrike-engine-git) as DATA_DIR
 In path /mnt/int/system/aur/vegastrike-engine-git
Vega Strike  
See http://www.gnu.org/copyleft/gpl.html for license details.

Using target data directory specified on command line: '/usr/share/vegastrike'
Invalid debug level specified
[evert@Evert vegastrike-engine-git]$

@stephengtuggy
main.cpp: The possible '--debug' options need to be '0', '1', etc. Th…
5470e73 
…ese correspond to '--debug=0' on the command line.
@stephengtuggy
Copy link
Contributor Author

Just tried running this, and it fails instantly:

[evert@Evert vegastrike-engine-git]$ vs
Starting Vega Strike...

Registering codec ogg
.
Legacy Mode: TRUE
Saving current directory (/mnt/int/system/aur/vegastrike-engine-git) as DATA_DIR
 In path /mnt/int/system/aur/vegastrike-engine-git
Vega Strike  
See http://www.gnu.org/copyleft/gpl.html for license details.

Using target data directory specified on command line: '/usr/share/vegastrike'
Invalid debug level specified
[evert@Evert vegastrike-engine-git]$

@evertvorster Just fixed that 😄

@stephengtuggy stephengtuggy mentioned this pull request Jan 18, 2025
Closed
@stephengtuggy stephengtuggy marked this pull request as ready for review January 18, 2025 17:16
@stephengtuggy stephengtuggy merged commit a1f41ca into vegastrike:master Jan 18, 2025
16 checks passed
@stephengtuggy stephengtuggy deleted the refac/boost_program_options_0.10.x branch January 18, 2025 19:24
@stephengtuggy stephengtuggy linked an issue Jan 19, 2025 that may be closed by this pull request
Make --target / -d options consistent between vegastrike-engine and vegasettings #638
Closed
@stephengtuggy stephengtuggy mentioned this pull request Jan 19, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjamenMeyer BenjamenMeyer BenjamenMeyer left review comments

@royfalk royfalk royfalk approved these changes

Assignees

@stephengtuggy stephengtuggy

Labels
enhancement
Projects
None yet
Milestone
0.10.x
4 participants
@stephengtuggy @evertvorster @BenjamenMeyer @royfalk