Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark/Light toggle not working #44

Open
slau8 opened this issue Aug 31, 2024 · 0 comments
Open

Dark/Light toggle not working #44

slau8 opened this issue Aug 31, 2024 · 0 comments

Comments

@slau8
Copy link

slau8 commented Aug 31, 2024

All of the data changes related to toggling seem functional (switching the toggle icon, updating local storage, adding/removing dark class from the body) — except for the color change itself!

Observed behavior:

  • Notion page set to light ➡️ custom domain stays light
  • dark ➡️ dark
  • system default (for me, dark) ➡️ dark

I reproduced this bug on both web & mobile.

Some investigating:

  • I noticed that the div.notion-app-inner's style remains dark — maybe that's related. Video below shows this behavior.

I couldn't figure it out, but if you have any more context on how body.classList.add('dark') drives the CSS color change, or ideas on how to debug this, lmk and I would love to try to fix this.

Screen.Recording.2024-08-31.at.16.21.46.mov
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant