fix: only show debug logs in 'development'

CodeGenieApp · Feb 2, 2021 · b0c4814 · b0c4814
1 parent 9543516
commit b0c4814
Show file tree

Hide file tree

Showing 2 changed files with 57 additions and 3 deletions.
diff --git a/__tests__/integration.js b/__tests__/integration.js
@@ -420,4 +420,39 @@ describe.each(EACH_MATRIX)('%s:%s: integration tests', (eventSourceName, framewo
     })
     expect(response).toEqual(expectedResponse)
   })
+
+  test('custom logger', async () => {
+    app = express()
+    router = express.Router()
+    app.use('/', router)
+    router.get('/users', (req, res) => {
+      res.json({})
+    })
+    const event = makeEvent({
+      eventSourceName,
+      path: '/users',
+      httpMethod: 'GET'
+    })
+    const customLogger = {
+      error: jest.fn(),
+      warn: jest.fn(),
+      info: jest.fn(),
+      verbose: jest.fn(),
+      debug: jest.fn()
+    }
+    serverlessExpressInstance = serverlessExpress({ app, log: customLogger })
+    await serverlessExpressInstance.handler(event)
+
+    expect(customLogger.debug.mock.calls.length).toBe(6)
+
+    // TODO: test log levels
+    // customLogger.level = 'error'
+    // customLogger.debug.mockClear()
+    // customLogger.debug.mockReset()
+    // customLogger.debug = jest.fn()
+
+    // serverlessExpressInstance = serverlessExpress({ app, log: customLogger })
+    // await serverlessExpressInstance.handler(event)
+    // expect(customLogger.debug.mock.calls.length).toBe(0)
+  })
 })
diff --git a/src/logger.js b/src/logger.js
@@ -1,18 +1,37 @@
 const logger = {
+  // TODO: allow users to set log level without having to provide the other log methods
+  level: process.env === 'development' ? 'debug' : 'error',
+  error (message, additional) {
+    if (!logger.level.includes('debug', 'verbose', 'info', 'warn', 'error')) return
+    console.error({
+      message,
+      ...additional
+    })
+  },
+  warn (message, additional) {
+    if (!logger.level.includes('debug', 'verbose', 'info', 'warn')) return
+    console.warn({
+      message,
+      ...additional
+    })
+  },
   info (message, additional) {
+    if (!logger.level.includes('debug', 'verbose', 'info')) return
     console.info({
       message,
       ...additional
     })
   },
-  debug (message, additional) {
+  verbose (message, additional) {
+    if (!logger.level.includes('debug', 'verbose')) return
     console.debug({
       message,
       ...additional
     })
   },
-  error (message, additional) {
-    console.error({
+  debug (message, additional) {
+    if (logger.level !== 'debug') return
+    console.debug({
       message,
       ...additional
     })