-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It works with Application Load Balancer! #241
Comments
Nice job man! I'm trying to do the same thing for ELB now. This helps a whole bunch! |
Nice! This is natively supported in v4 |
fredericgermain
added a commit
to fredericgermain/serverless-express
that referenced
this issue
Mar 25, 2021
2 tasks
fredericgermain
added a commit
to fredericgermain/serverless-express
that referenced
this issue
Mar 25, 2021
brettstack
pushed a commit
that referenced
this issue
Jun 9, 2021
OneDev0411
added a commit
to OneDev0411/serverless-express
that referenced
this issue
Mar 16, 2023
## [4.3.9](CodeGenieApp/serverless-express@v4.3.8...v4.3.9) (2021-06-09) ### Bug Fixes * auto-unescape query parameters on ALB ([#219](CodeGenieApp/serverless-express#219), [#241](CodeGenieApp/serverless-express#241)) ([#393](CodeGenieApp/serverless-express#393)) ([8cb4206](CodeGenieApp/serverless-express@8cb4206))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey there, I was interested in trying out ALB instead of API Gateway for performance reasons.
I managed to get it working with the following code:
The trick was parsing the encoded query parts, annoyingly ALB did this automatically.
I set them back onto both
queryStringParameters
(ALB) andquery
(API Gateway) so it's compatible with both event types.Do you think it would make sense to merge the
decodeURIComponent
stuff into the library?It seems to be harmless if things are already decoded.
The text was updated successfully, but these errors were encountered: