fix: auto-unescape query parameters on ALB (#219, #241) #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredericgermain
force-pushed
the
pr/escape_query_parameters_on_alb
branch
from
65fe415 to
91a8790
Compare
fredericgermain
changed the title
|
Hey! Thanks for this. Could you add a test? 🙏 |
|
Note that this also adds support for ALB messages that have queryStringParameters instead of multiQueryStringParameters (which is apparently an option). Looking forward to seeing it merged! |
This was referenced Jun 9, 2021
|
🎉 This PR is included in version 4.3.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Thanks! |
|
Thanks @fredericgermain |
OneDev0411
added a commit
to OneDev0411/serverless-express
that referenced
this pull request
Mar 16, 2023
## [4.3.9](CodeGenieApp/serverless-express@v4.3.8...v4.3.9) (2021-06-09) ### Bug Fixes * auto-unescape query parameters on ALB ([#219](CodeGenieApp/serverless-express#219), [#241](CodeGenieApp/serverless-express#241)) ([#393](CodeGenieApp/serverless-express#393)) ([8cb4206](CodeGenieApp/serverless-express@8cb4206))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#219, #241
Description of changes:
This will auto-unescape query parameters in ALB. And avoid the hacks found in #219
#241 was closed, because of ALB support in v4 maybe? But the unescape part was important in the ticket, but I couldn't see anything like that on the main branch.
It could be a breaking change for people who already handle this case. It's maybe better integrated on a mayor version.
It was made with the assumption that Api gateway ports already auto-unescape these parameters. But I'm not sure of that.
Some of the changes could be better made in
src/event-sources/utils.jsanyway.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.