Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native SNS and DynamoDB Support #468

Merged
merged 8 commits into from
Oct 6, 2021

Conversation

cnuss
Copy link
Contributor

@cnuss cnuss commented Oct 4, 2021

Description of changes:

  • Add native request/response handlers for SNS and DynamoDB events

Checklist

  • Tests have been added and are passing
  • Documentation has been updated

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@cnuss
Copy link
Contributor Author

cnuss commented Oct 4, 2021

@brettstack Could you have a look at this PR? Let me know if you have any comments/suggestions/issues with this!

Thanks!

Copy link
Collaborator

@brettstack brettstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks! Just one thing to remove is the manual version update in package.json. I'll merge this as a feat: commit message and it'll automatically get published as that version. Do you have examples you're able to commit also? Thanks again!

package.json Outdated Show resolved Hide resolved
@cnuss
Copy link
Contributor Author

cnuss commented Oct 6, 2021

@brettstack removed the package.json modification of the version number

Re: examples -- I'll whip together an example, but could I do it as another PR, or would you like one as part of this PR?

@brettstack brettstack merged commit 276a6da into CodeGenieApp:mainline Oct 6, 2021
github-actions bot pushed a commit that referenced this pull request Oct 6, 2021
# [4.4.0](v4.3.12...v4.4.0) (2021-10-06)

### Features

* add support for SNS and DynamoDB event sources ([#468](#468)) ([276a6da](276a6da))
@github-actions
Copy link

github-actions bot commented Oct 6, 2021

🎉 This PR is included in version 4.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@brettstack
Copy link
Collaborator

Thanks @cnuss! This is a great addition. Best of luck with Scaffoldly.

@cnuss
Copy link
Contributor Author

cnuss commented Oct 6, 2021

thanks @brettstack! serverless-express has been amazing

if you'd like to connect and learn a little about Scaffoldly, I'm looking for some early feedback and would be happy to show you around. hit me up! my LinkedIn and Twitter details are in my bio

@cnuss cnuss deleted the sns-and-ddb branch October 6, 2021 19:53
@cnuss cnuss mentioned this pull request Oct 28, 2021
2 tasks
@H4ad H4ad mentioned this pull request Dec 24, 2021
2 tasks
OneDev0411 added a commit to OneDev0411/serverless-express that referenced this pull request Mar 16, 2023
# [4.4.0](CodeGenieApp/serverless-express@v4.3.12...v4.4.0) (2021-10-06)

### Features

* add support for SNS and DynamoDB event sources ([#468](CodeGenieApp/serverless-express#468)) ([276a6da](CodeGenieApp/serverless-express@276a6da))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants