fix: ensure response header value is string type #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM could you please remove the package-lock.json from the commit first |
etamity
force-pushed
the
fix-response-value-type
branch
from
7998aaa to
1c84ce5
Compare
|
Thanks @etamity ! |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 14, 2021
## [4.5.2](v4.5.1...v4.5.2) (2021-10-14) ### Bug Fixes * ensure response header value is string type ([#474](#474)) ([cb4b0e8](cb4b0e8))
|
🎉 This PR is included in version 4.5.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
OneDev0411
added a commit
to OneDev0411/serverless-express
that referenced
this pull request
Mar 16, 2023
## [4.5.2](CodeGenieApp/serverless-express@v4.5.1...v4.5.2) (2021-10-14) ### Bug Fixes * ensure response header value is string type ([#474](CodeGenieApp/serverless-express#474)) ([cb4b0e8](CodeGenieApp/serverless-express@cb4b0e8))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multiValueHeaders and headers maps while processing the integration response
into a single
Map<String, List>valuehttps://kevinhakanson.com/2019-10-25-aws-alb-lambda-function-targets-and-multi-value-headers
https://javadoc.io/static/com.amazonaws/aws-lambda-java-events/2.2.7/com/amazonaws[…]services/lambda/runtime/events/APIGatewayProxyRequestEvent.html
getMultiValueHeaders()return as Map<String,List>currently there are some header value are not string type (e.g
content-length), which will cause 502 error on awselb/api gateway layer.so we need to transform all headers value as string
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.