feat(core): Add CSV import in multiple languages #1199
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turned out a little more complex than anticipated. I tried to maintain as much compatibility with the monolingual import as possible, but this required adding an optional
mainLanguage
parameter toparseProducts
, which is used to specify the language to use for theProduct.name
,Product.slug
, etc. properties. So even though theParsedProduct
andParsedProductVariant
interfaces have additional properties now, I think it should be compatible with most, if not all, existing usages. Not sure if you consider this a breaking change.Also a note: I pushed with
--no-verify
, because there's an error during e2e testing:It wasn't me! 😬 It was already broken before I made any changes! 😬😉 (and I also didn't investigate it any further yet)