Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vendure entity events #1222

Merged
merged 8 commits into from
Nov 23, 2021
Merged

Vendure entity events #1222

merged 8 commits into from
Nov 23, 2021

Conversation

Draykee
Copy link
Contributor

@Draykee Draykee commented Nov 15, 2021

A work in progress PR to review changes and disscuss.

@Draykee Draykee marked this pull request as draft November 15, 2021 13:55
@Draykee Draykee marked this pull request as ready for review November 15, 2021 13:55
@Draykee Draykee marked this pull request as draft November 15, 2021 13:57
@Draykee Draykee marked this pull request as ready for review November 17, 2021 22:39
@Draykee Draykee changed the title [WIP] Vendure entity events Vendure entity events Nov 17, 2021
michaelbromley
michaelbromley requested changes Nov 22, 2021
View reviewed changes
Copy link
Member

@michaelbromley michaelbromley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an absolutely epic PR, thank you so much for all the work you put in on it! Just a few minor points to address. Regarding the Order-related events, I will take a look at that once these changes are merged in.

packages/core/src/event-bus/events/asset-event.ts Outdated Show resolved Hide resolved
packages/core/src/event-bus/events/coupon-code-event.ts Outdated Show resolved Hide resolved
packages/core/src/event-bus/events/customer-group-entity-event.ts Show resolved Hide resolved
packages/core/src/event-bus/events/history-entry-event.ts Outdated Show resolved Hide resolved
packages/core/src/event-bus/vendure-entity-event.ts Outdated Show resolved Hide resolved
packages/core/src/service/services/customer.service.ts Outdated Show resolved Hide resolved
@michaelbromley michaelbromley linked an issue Nov 22, 2021 that may be closed by this pull request
More Events for each entity #1219
Closed
@michaelbromley michaelbromley merged commit edc9d69 into vendure-ecommerce:minor Nov 23, 2021
@michaelbromley
Copy link
Member

Thank you!

@Draykee Draykee mentioned this pull request Nov 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbromley michaelbromley michaelbromley requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

More Events for each entity
2 participants
@Draykee @michaelbromley