Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(job-queue-plugin)!: Update bullmq & redis dependencies #2020

Conversation

alexisvigoureux
Copy link
Contributor

🎯 Goal

Update bullmq and ioredis dependencies

📝 Approach

  • Removal of the QueueScheduler class from the job-queue-plugin due to the bullmq refactoring in v2.
  • @types/ioredis is deprecated, ioredis provides its own type definitions now with the v5. The migration was made by following the guideline.

BREAKING CHANGE: The minimum Redis recommended version is 6.2.0 link.
(that’s why the PR is made against the major branch)

Note

The getAllBufferIds function is called 2 times: call 1, call2 but the variable is not used. So I didn't add a workaround to the missing scanstream function on Redis cluster

BREAKING CHANGE: The minimum Redis recommended version is 6.2.0.
@michaelbromley
Copy link
Member

Thanks for the PR!

I'll properly review this once I've finished a couple of other tasks on the major branch.

@xrev87
Copy link

xrev87 commented Feb 13, 2023

The only thing you might find here is that TypeORM 0.2.45 has a peer dependency on an older version of IORedis

@michaelbromley michaelbromley merged commit eb0b73f into vendure-ecommerce:major Mar 20, 2023
@alexisvigoureux alexisvigoureux deleted the chore/job-queue-plugin-dependencies branch March 20, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants