fix(core): Delete user sessions & token upon user-deletion #2241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This applies to both admins and regular users.
✅ Deploy Preview for effervescent-donut-4977b2 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
DanielBiegler
commented
Jun 21, 2023
Comment on lines
+175
to
+178
| // Dynamic import to avoid the circular dependency of SessionService | ||
| await this.moduleRef | ||
| .get((await import('./session.service.js')).SessionService) | ||
| .deleteSessionsByUser(ctx, new User({ id: userId })); |
There was a problem hiding this comment.
@michaelbromley For now I just constructed the User to be able to use the deleteSessionsByUser function - it might be cleaner to refactor? The deletion function only uses the userId anyway. Whats your more experienced-perspective on this? Cheers.
There was a problem hiding this comment.
Yes I agree it makes more sense for that deleteSessionsByUser to just take an ID rather than the User object. But since that's a public method, I would err on the side of caution and not change the signature in a breaking way. We could overload it so it can take a User object or an ID though, which would be a backward-compatible change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies to both admins and regular users.