Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin-ui): Fix query filter option in order list component #2258

Merged

Conversation

cdiban
Copy link
Contributor

@cdiban cdiban commented Jun 30, 2023

Relates to #2257. This commit add customerLastName and id filters

Relates to vendure-ecommerce#2257. This commit add customerLastName and id filters
@netlify
Copy link

netlify bot commented Jun 30, 2023

Deploy Preview for effervescent-donut-4977b2 canceled.

Name Link
🔨 Latest commit cdb8481
🔍 Latest deploy log https://app.netlify.com/sites/effervescent-donut-4977b2/deploys/64a2d2acef9bef00084b0995

@michaelbromley
Copy link
Member

Thanks for the contribution! The original functionality (as in v1.x) was to filter by transaction id rather than the order id - the transaction ID being the id generated by the payment gateway.

There is a filter input named transactionId for this purpose.

Could you update to use that filter rather than id?

@cdiban
Copy link
Contributor Author

cdiban commented Jul 3, 2023

Thanks for the contribution! The original functionality (as in v1.x) was to filter by transaction id rather than the order id - the transaction ID being the id generated by the payment gateway.

There is a filter input named transactionId for this purpose.

Could you update to use that filter rather than id?

Of course, thank you for the clarification. I pushed a new commit.

Best.
Carlo.

@michaelbromley michaelbromley merged commit 7b56942 into vendure-ecommerce:master Jul 3, 2023
@michaelbromley
Copy link
Member

Thank you! This will be part of the upcoming 2.0.3 patch release 👍

@cdiban cdiban deleted the fix/order-list-query-filter branch July 5, 2023 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants