Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin-ui): Add product variant name filter in product variant list #2271

Merged
merged 4 commits into from
Jul 13, 2023

Conversation

cdiban
Copy link
Contributor

@cdiban cdiban commented Jul 6, 2023

Since the v2.0.3 product variants list can't filter by name. In my opinion, a name filter is essential in business with thousands of product variants in each product.

@netlify
Copy link

netlify bot commented Jul 6, 2023

Deploy Preview for effervescent-donut-4977b2 canceled.

Name Link
🔨 Latest commit 121f462
🔍 Latest deploy log https://app.netlify.com/sites/effervescent-donut-4977b2/deploys/64a60b0635c3210008d197f8

@cdiban
Copy link
Contributor Author

cdiban commented Jul 13, 2023

@michaelbromley What do you thing about this filter?

@michaelbromley michaelbromley merged commit b17494d into vendure-ecommerce:master Jul 13, 2023
@michaelbromley
Copy link
Member

Yep this is good, thanks for the contribution!

@cdiban cdiban deleted the fix/minors branch July 14, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants