Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More actions under add widget translations hardcoded #2334

Closed
wpplumber opened this issue Aug 3, 2023 · 5 comments
Closed

More actions under add widget translations hardcoded #2334

wpplumber opened this issue Aug 3, 2023 · 5 comments
Assignees
Labels
type: bug 🐛 Something isn't working

Comments

@wpplumber
Copy link
Contributor

Describe the bug
When visiting dashboard with RTL Arabic the more actions under add widget button items' text hardcoded. (see screenshot)

image

@wpplumber wpplumber added the type: bug 🐛 Something isn't working label Aug 3, 2023
@wpplumber
Copy link
Contributor Author

@michaelbromley, what is the best way to work on this issue?

@michaelbromley
Copy link
Member

Hi! Thanks for bringing this to my attention. I just took a look and saw that we are failing to use the title property in that list. This will be fixed in the upcoming patch release.

@wpplumber
Copy link
Contributor Author

What are the term in case I want to participate with Angular contribution, is it best to create an issue and wait for feedback or going straight to PR?

@michaelbromley
Copy link
Member

Create an issue first and indicate that you'd like to work on it. In this case, I was already making some changes to the admin UI when I read the issue, so just decided to handle it myself - it was easier than explaining in that case.

But I do want to encourage participation so if you want to work on a particular issue, just make it known and I'll know not to do it myself.

@wpplumber
Copy link
Contributor Author

Clear, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants