feat(admin-ui): Add product slug in product multi selector dialog component #2461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for effervescent-donut-4977b2 canceled.
|
michaelbromley
requested changes
Oct 17, 2023
...shared/components/product-multi-selector-dialog/product-multi-selector-dialog.component.html
Outdated
Show resolved
Hide resolved
michaelbromley
merged commit b7f3452
into
vendure-ecommerce:master
10 of 14 checks passed
|
Awesome! Thank you 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial issue
When trying to fill in the collections by manually selecting products, we sometimes have issues because products of different sellers have the exact same names.
For instance, we have a lot of
Amazonproducts which we can't distinguish between all our vendors.Solution
In this PR, I enhanced the
product-multi-selector-dialogAngular component so as to display the productslugin case the display mode isproduct.Therefore, we know exactly what product corresponds to each card.