Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(admin-ui): Use generics in ReactDataTableComponentProps #2500

Conversation

barakamwakisha
Copy link
Contributor

Description

Add generics to ReactDataTableComponentProps
Fixes #2486

Breaking changes

None

Checklist

📌 Always:

  • I have set a clear title
  • My PR is small and contains a single feature
  • I have checked my own PR

⚡ Most of the time:

  • I have added or updated test cases
  • I have updated the README if needed

Copy link

netlify bot commented Oct 31, 2023

Deploy Preview for effervescent-donut-4977b2 canceled.

Name Link
🔨 Latest commit 54cf336
🔍 Latest deploy log https://app.netlify.com/sites/effervescent-donut-4977b2/deploys/65440d85727c0c000858dc4d

@michaelbromley
Copy link
Member

Thanks for this! Since this will be coming in a patch release, I'd like to add a default generic type of any so that it does not act as a breaking change for anyone already using this type.

@barakamwakisha
Copy link
Contributor Author

Ok. I made the change.

@michaelbromley michaelbromley merged commit 730a103 into vendure-ecommerce:master Nov 3, 2023
14 checks passed
@michaelbromley
Copy link
Member

Thank you!

@barakamwakisha barakamwakisha deleted the react-data-table-generics branch November 6, 2023 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReactDataTableComponentProps should use generics so that rowItem is T instead of any
2 participants