fix(elasticsearch plugin): 🐛 fix type to allow the promise on custom mapping definition #2562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mapping definition
✅ Deploy Preview for effervescent-donut-4977b2 canceled.
|
|
@michaelbromley if you can insert this in the next minor is a very very small change FYI @LorenzoRottigni |
|
Thanks for the fix! |
|
👍 |
alexisvigoureux
pushed a commit
to alexisvigoureux/vendure
that referenced
this pull request
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refer to: #2543 (comment)
Description
Breaking changes
Does this PR include any breaking changes we should be aware of? NO
Screenshots
You can add screenshots here if applicable.
Checklist
📌 Always:
⚡ Most of the time: