fix(core): Handle nullable relations in EntityHydrator #2683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for effervescent-donut-4977b2 canceled.
|
|
Thanks for the report and PR! Looks like a slight adjustment is needed to the e2e test for mysql/mariaDB though. |
jnugh
force-pushed
the
entity-hydrator-null
branch
from
8835ca9 to
1353506
Compare
|
Right, I created the sub relation with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2682
Description
I already described the issue in #2682. The EntityHydrator crashes if a nested relation should be hydrated but the parent is nullable.
Checklist
📌 Always:
👍 Most of the time: