fix(admin-ui): Product variant auto-rename bug #2680 #2684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for effervescent-donut-4977b2 canceled.
|
Anddrrew
changed the title
michaelbromley
merged commit 2075d6d
into
vendure-ecommerce:master
17 of 18 checks passed
|
Thank you for this PR! A very elegant refactor too 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the issue reported in #2680, where product updates were being blocked due to a bug with the variant auto-rename feature. The root cause was identified as incorrect type annotations.
Changes
removeReadonlyCustomFields&removeReadonlyisEntityCreateOrUpdateMutationfunction has been moved to a separate fileBreaking changes
Null
Checklist
📌 Always:
👍 Most of the time: