Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin-ui): Require default currency and language for channels #2722

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

oidt
Copy link
Contributor

@oidt oidt commented Mar 7, 2024

Description

PR for this bug: #2718

Screenshots

image

Copy link

netlify bot commented Mar 7, 2024

Deploy Preview for effervescent-donut-4977b2 canceled.

Name Link
🔨 Latest commit e8c44b7
🔍 Latest deploy log https://app.netlify.com/sites/effervescent-donut-4977b2/deploys/65ead321df282700073dc2c2

@oidt
Copy link
Contributor Author

oidt commented Mar 7, 2024

I put default language under available language and the same for currencies.
Changed warn under default shipping zone to danger because it is a required field just like default tax zone.
could not found any e2e for this part, if we have please let me know I will update the PR.

@michaelbromley michaelbromley merged commit 7859a15 into vendure-ecommerce:master Apr 3, 2024
17 of 18 checks passed
@michaelbromley
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants