Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Fix stock constraint error for adjustOrderLine when using OrderLine custom fields #2737

Conversation

andriinuts
Copy link
Contributor

Description

Fixes #2736

Breaking changes

No

Checklist

📌 Always:

  • I have set a clear title
  • My PR is small and contains a single feature
  • I have checked my own PR

👍 Most of the time:

  • I have added or updated test cases
  • I have updated the README if needed

Copy link

netlify bot commented Mar 13, 2024

Deploy Preview for effervescent-donut-4977b2 ready!

Name Link
🔨 Latest commit 47e6091
🔍 Latest deploy log https://app.netlify.com/sites/effervescent-donut-4977b2/deploys/65f1f0cb845d86000804f358
😎 Deploy Preview https://deploy-preview-2737--effervescent-donut-4977b2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andriinuts
Copy link
Contributor Author

please restart the checks because sometimes tests fail with Error: listen EADDRINUSE: address already in use :::3012, or can we manually restart them with some command?

@michaelbromley michaelbromley merged commit 8a961b0 into vendure-ecommerce:master Mar 18, 2024
17 of 18 checks passed
@michaelbromley
Copy link
Member

Thank you, excellent work on the e2e tests too 👍

The e2e tests can be flaky regarding the port conflict. I've yet to dedicate the time to figuring that out.

@andriinuts andriinuts deleted the fix/2736-adjust-order-line-stock-on-hand branch March 18, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stock validation not working as expected with OrderLine custom fields when using adjustOrderLine
2 participants