fix(default-search-plugin): Fix channels swapping and not swapping back in saveVariants when working with multiple channels #3041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k in saveVariants when working with multiple channels Relates to vendure-ecommerce#3012.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
michaelbromley
merged commit 75ed6e1
into
vendure-ecommerce:master
12 of 14 checks passed
|
Thanks for the quick fix! 🙏 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #3012.
Description
While indexing variants, a product for a specific variant is queried. However, somewhere in the code the channels are being swapped if multiple channels exist, and they are not being swapped back, which is resulting in the product not being found for that channel as they don't exist, which is making the indexing fail. that's why I have added a line in the code that swaps the channels back to the original one at the start of every loop, and a line at the end of the loop.