Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle empty state for product and variant id filter of collections #3064

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

dlhck
Copy link
Collaborator

@dlhck dlhck commented Sep 13, 2024

Description

When a collection uses a product-id-filter or a variant-id-filter and the selected IDs are empty, it gets assigned to every product or product variant in the catalog.

Breaking changes

No

Checklist

📌 Always:

  • I have set a clear title
  • My PR is small and contains a single feature
  • I have checked my own PR

Copy link

vercel bot commented Sep 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Sep 13, 2024 1:24pm

Copy link
Contributor

github-actions bot commented Sep 13, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@dlhck
Copy link
Collaborator Author

dlhck commented Sep 13, 2024

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Sep 13, 2024
@michaelbromley michaelbromley merged commit 9a03c84 into master Sep 13, 2024
14 checks passed
@michaelbromley michaelbromley deleted the fix/collection-empty-filters branch September 13, 2024 14:29
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants