Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Do not include deleted variants when indexing productInStock #3110

Conversation

kyunal
Copy link
Contributor

@kyunal kyunal commented Oct 5, 2024

Description

This fixes #3109

Breaking changes

Screenshots

Checklist

📌 Always:

  • I have set a clear title
  • My PR is small and contains a single feature
  • I have checked my own PR

👍 Most of the time:

  • I have added or updated test cases
  • I have updated the README if needed

Copy link

vercel bot commented Oct 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Oct 5, 2024 1:21pm

Copy link
Contributor

github-actions bot commented Oct 5, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@kyunal
Copy link
Contributor Author

kyunal commented Oct 5, 2024

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Oct 5, 2024
@michaelbromley michaelbromley merged commit 73cb190 into vendure-ecommerce:master Oct 14, 2024
29 checks passed
@michaelbromley
Copy link
Member

Thank you for the fix!

@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DefaultSearchPlugin: Product can be falsely indexed as in stock if a deleted variant has stock
2 participants