Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

from keyword in import tags and of keyword in for loop tags are not highlighted #1

Open
uncenter opened this issue Nov 28, 2024 · 2 comments

Comments

@uncenter
Copy link

Same vein as ventojs/vscode-vento#11, with the addition of of. Possibly other keyword too, I'll do a proper check. I don't have a minute to work on this myself yet (likely until this weekend) but thought I'd mention it in case you have some time on your hands!

@wrapperup
Copy link
Collaborator

wrapperup commented Nov 28, 2024

Hey, thanks for making an issue! The grammar here is pretty naive, since it only assumes a few keywords are part of vento (in theory, it's very flexible due to extensions), so currently it relies a bit on tree-sitter-javascript to fill in the gaps.

I can add the the special cases like from and such, since those are handled natively in vento, and should be added. Let me know which ones you're missing and I'll add em :).

@uncenter
Copy link
Author

Gotcha yeah, I was taking a peek around earlier - I've been working with Tree-sitter grammars frequently recently so I'm getting used to it 😅 Would be great if you could add those two keywords, not any others I can think of at the minute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants