Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are RuntimeExceptions really intended? #1033

Open
michaelknigge opened this issue Jul 12, 2019 · 1 comment
Open

Are RuntimeExceptions really intended? #1033

michaelknigge opened this issue Jul 12, 2019 · 1 comment
Assignees
Labels
feature New functionality to be developed P2 Medium priority issues to be scheduled in a future release
Milestone

Comments

@michaelknigge
Copy link

I looked through the issues at https://app.codacy.com/app/veraPDF/veraPDF-parser/issues and asked myself if it is really the desired behavior that veraPDF throws RuntimeExceptions?

For example, let's have a look at Writer.visitFromStream(COSStream obj) - if an IOException occurs, veraPDF will throw a RuntimeException. Why? Is it really the desired behavior that veraPDF (probably) terminates an application if (for example) the disk is full?

IMHO a library should never tear down an application - if the application should exit/terminate or not is the responsibility of the application. I usually would not expect that....

Bye,
Michael

@carlwilson
Copy link
Contributor

Hi again @michaelknigge I'll be leaving this open for now. The behaviour you describe sounds neither desirable or intentional and we'll review over the development period for the next release. Thanks.

@ghost ghost assigned carlwilson Oct 24, 2019
@ghost ghost added the question label Oct 24, 2019
@bdoubrov bdoubrov added feature New functionality to be developed P2 Medium priority issues to be scheduled in a future release labels Feb 10, 2021
@carlwilson carlwilson added this to the 1.22 milestone Feb 1, 2022
@bdoubrov bdoubrov modified the milestones: 1.22, 1.26 Jul 4, 2023
@MaximPlusov MaximPlusov modified the milestones: 1.26, 1.28 May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality to be developed P2 Medium priority issues to be scheduled in a future release
Projects
None yet
Development

No branches or pull requests

4 participants