Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "expired" status for Code queries #110

Open
pixelmachine opened this issue Dec 8, 2022 · 3 comments
Open

Add "expired" status for Code queries #110

pixelmachine opened this issue Dec 8, 2022 · 3 comments

Comments

@pixelmachine
Copy link

pixelmachine commented Dec 8, 2022

The docs say that a code query can be made on the status of a code with the statuses 'live', 'pending', 'expired', 'disabled'.

However a code can't be pending and it doesn't look like the 'expired' status exists for codes, though they certainly can expire.

Secondly you can query a code based on it's expiry date but that's not mentioned in the docs.

Plugin version

2.7.3 (and 3)

@engram-design
Copy link
Member

Looks like just a docs issue, which I've updated. There are no live, pending or expired statuses for Codes, just enabled or disabled.

@pixelmachine
Copy link
Author

Would be good if there were an expired status for codes though, since that's a key feature of a code! Would allow you to retrieve all expired codes regardless of date.

@engram-design
Copy link
Member

Sure, I'll switch this to a feature request for that!

@engram-design engram-design reopened this Dec 10, 2022
@engram-design engram-design changed the title Code query status and expiry date Add "expired" status for Code queries Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants