Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.9.0: related.list / toc problems #103

Open
tunnckoCore opened this issue Oct 24, 2016 · 12 comments
Open

0.9.0: related.list / toc problems #103

tunnckoCore opened this issue Oct 24, 2016 · 12 comments
Labels

Comments

@tunnckoCore
Copy link

Not sure for where the problem come, but i have

"toc": {
  "render": true,
  "method": "preWrite",
  "maxdepth": 4
}

and when ran verb --config related.list:... it overrides the toc option to true.

Again, not sure enough. Before didn't have such problems and don't know from when it is (if it is actual bug)

@jonschlinkert
Copy link
Member

jonschlinkert commented Oct 24, 2016

really? that's strange.

marking as a bug

@jonschlinkert
Copy link
Member

do you have a global config? this would still be a bug, but is there a chance that verb is somehow merging your global config over the local config?

Also, try using a = as a separator:

$ verb --config=related.list:foo,bar,baz

@tunnckoCore
Copy link
Author

do you have a global config?

I believe i deleted them with ~/.dat* (date-store and data-store)

But yea, I'll try in clean folder and no global config, and i'll back.

@tunnckoCore
Copy link
Author

tunnckoCore commented Oct 24, 2016

Yea, still resets the toc option, even after deletion of global stores.

https://asciinema.org/a/0xbhmy7egjfbacd8uapzbdllj

(edit: 1) with = is same; 2) with adding <!-- toc --> too)

@jonschlinkert
Copy link
Member

Ok, that makes it easier thx. I was hoping it was just a glitch in verb itself, probably in the task logic or how the defaults are setup. This at least means that the global config isn't related to the issue

@tunnckoCore
Copy link
Author

tunnckoCore commented Mar 30, 2017

@jonschlinkert do you know from where problem comes to navigate me so i can PR, cuz it is very weird. Moreover when I almost every day publish new package. ;d

edit: because I maybe don't have time to debug. (saying "maybe" because I always say it that way but I always debugging and finding it ;d)

@jonschlinkert
Copy link
Member

it still does this?

do you know from where problem...

No, not yet. But I suspect it comes from base-cli-process or base-cli-schema (probably the former).

@tunnckoCore
Copy link
Author

it still does this?

yea

But I suspect it comes from

ookey, i'll look what's up there, thanks

@tunnckoCore
Copy link
Author

tunnckoCore commented Mar 30, 2017

I believe that the problem is somewhere here base-cli-process/index.js#L50-L58. It seems that the passed obj to the var fn = this.cli.process is not correct, but the opts is correct. So sounds like problem in the *-schema's .normalize? hm 🤔

edit: in obj is toc: { render: true } and in opts is toc: { render: true, method: 'preWrite', maxdepth: 3 } }

edit2: daaamn, i don't know ;d

@tunnckoCore
Copy link
Author

forget that, nothing related ;d

@jonschlinkert
Copy link
Member

ok, so the problem still exists, and we're not sure where it's happening?

@tunnckoCore
Copy link
Author

Yea, absolutely.

Maybe the easy fix can be if we allow everything to be controlled through <!-- toc --> (if it isn't possible currently, i'm not sure), it would look like as it is CLI.

I was debugging few hours and didn't detect where the problem comes from. It may be in the verbose/verb-toc too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants