Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needs CI tests for Windows #7

Open
TooTallNate opened this issue Mar 25, 2019 · 6 comments
Open

Needs CI tests for Windows #7

TooTallNate opened this issue Mar 25, 2019 · 6 comments

Comments

@TooTallNate
Copy link
Member

TooTallNate commented Mar 25, 2019

Possibly using CircleCI for Windows beta, or AppVeyor.

@markozxuu
Copy link

@TooTallNate Our best option for now is to use AppVeyor. Circle CI it still does not stable release the support for Windows

This was referenced Apr 5, 2019
@timneutkens
Copy link
Member

We've been very successful with Azure Pipelines on Next.js:
https://azure.microsoft.com/en-us/services/devops/pipelines/

I think now-desktop also uses it.

@amio
Copy link
Contributor

amio commented Apr 5, 2019

Azure Pipelines looks promising, let's give it a try 👍

Two PRs for this:

  1. Get build script compatible with windows (Add a windows compatible build script #12)
  2. Update azure pipelines config for testing with windows image (Update azure pipelines configuration #13)

@markozxuu
Copy link

@amio If we are going to use Azure pipeline I recommend deleting the add/appveyor-configuration branch. I see no case that continues to exist 👀

Screen Shot 2019-04-06 at 00 31 49

@amio
Copy link
Contributor

amio commented Apr 6, 2019

@mapeso Yep, branch deleted. I also disabled appveyor webhook, no more alert from appveyor now 😎

@markozxuu
Copy link

@amio Great !! 😺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants