-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text is "burnt" into background #1008
Comments
Are you using transparency? |
Yes the opacity on the background is half in the images provided. But it does not have to be half, I can see it at 0.8 as well, it's just easier to see at 0.5 which is what my theme is set to. |
Yep so the reason I introduced opacity was "optimistic". There are some Electron issues still with transparency :( |
And by Electron I potentially mean Chromium as well |
Yea there was some discussion of it being a potential Electron issue on the slack channel. Do you still want to keep this ticket open until it is resolved on their end? (no telling when or if it will be) |
@rauchg The macOS transparency has been natively added to electron recently |
So, have we tried reproducing this with Hyper + latest electron? Thanks for letting me know |
@rauchg No, It was talked today in slack see PR from electron |
@ppot Vibrancy is not just transparency, right? I think Electron has had transparency for a while with frameless windows like Hyper.app is. |
@codetheory Good question, I can't tell! |
I believe that's the case. In which case, Electron version shouldn't matter. |
@andydude What version you have. Since you have the path_helper in you're header it might be related to your version. Did you try the lastest master? |
If it's any help, this reminds me of an issue Terminal.app had, where if you selected a text shadow with a transparent background, the shadows would stick around when the text moved. AFAICT they "solved" it by removing the text shadow option :) |
I have this issue on my MacbookPro Retina 13" touchbar with Sierra last version, but it's not happening with my Hackintosh with a nVidia 980GTX. It might be hardware/graphics/driver related? |
I'm experiencing this on my Mid 2014 Retina Macbook Pro 15", with Intel Iris Pro 1536 MB graphics. I too have a partly transparent background color, set in the regular config file. I haven't looked at the code, but perhaps the terminal is getting cleared by "painting" the background color over the existing text? That would cause the text to only get partially faded out if the background is semitransparent, which is exactly the behavior I'm seeing. |
Seems duplicate #808 |
Fixed in v2 🎉 |
@albinekb Great news! I'm curious about the nature of the problem. Is there a commit you can reference that specifically addresses this? |
No @trueter, we have worked during almost a year to switch the terminal rendering library from |
This is still happening for me with Hyper v2 on OS X. It will happen if I move the Hyper window to another screen, or if I do something like close and open my laptop. |
I think I have the same problem as ajcrites |
having the same issue . |
Issue
When you lose focus on Hyper window and then return focus the text will become "burnt" into the background. The effect is removed if you lose focus and then apply focus to window again.
You can view the text by typing
clear
into the terminal and hittingenter
.Also can be done by reaching the end of the terminal window and continue to press
enter
causing the window to scrollHyper's default theme with the exception of the opacity change to view the "burnt" effect.
My normal terminal theme.
The text was updated successfully, but these errors were encountered: