Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copying line-break also copy the inserted newline. (shouldnt) #1911

Closed
neolectron opened this issue Jun 7, 2017 · 8 comments
Closed

Copying line-break also copy the inserted newline. (shouldnt) #1911

neolectron opened this issue Jun 7, 2017 · 8 comments

Comments

@neolectron
Copy link

  • [x ] I am on the latest Hyper.app version

  • [x ] I have searched the issues of this repo and believe that this is not a duplicate

  • w10 last build:

  • Hyper.app 1.3.3:

  • Link of a Gist with the contents of my .hyper.js:

  • The issue is reproducible in vanilla Hyper.app:

Issue

When I have long lines, hyper fit them on screen with a newline. (OK)
but when i copy it, it copy the "fake newline" . and it shouldnt. (very annoying)

DEMO :

https://puu.sh/wdgbY/1b6991a482.gif

Thanks for help :)

@yolocs
Copy link

yolocs commented Oct 18, 2017

Facing the same annoying issue all the time.

@albinekb
Copy link
Contributor

albinekb commented Oct 18, 2017

Hi! Could you please try the canary release channel, learn how to switch at https://zeit.co/blog/canary

In 2.x (coming soon ™️) we have replaced the whole terminal rendering library from hterm to xterm.js, xterm is much more mature and there's a chance this is an issue with hterm.

However this could also be something wrong with hyper, but please check if you can reproduce it in 2.x and we'll take it from there 💪

@carragom
Copy link

carragom commented Nov 9, 2017

Hi there, having this same issue, using 2.1.1 on Windows 10 with WSL. This problem looks similar to microsoft/vscode#23142 and seems to be solved in xtermjs/xterm.js#443. Will this be fixed on the next release?

@chabou
Copy link
Collaborator

chabou commented Nov 9, 2017

hyper v2.1.1 uses xtermjs v2.9.2 and has already this patch, landed in xtermjs v2.8.0.

@carragom
Copy link

carragom commented Nov 9, 2017

Excellent news. But then I have no idea why it is not working.

@mcrump001
Copy link

mcrump001 commented Jan 29, 2018

I too am experiencing this issue with the latest version of hyper.js and Windows 10. Are there any updates on this?

@jleaders
Copy link

jleaders commented Apr 11, 2018

I have the same issue, Hyper 1.4.8 on Windows 10

I repro it by copying and pasting this text into hyper

echo hello
echo world

And I get

echo hello

echo world

@chabou
Copy link
Collaborator

chabou commented Apr 12, 2018

@jleaders It has been fixed in our canary (upcoming v2). See #1448

@chabou chabou closed this as completed Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants