Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh hotkey (Ctrl + R) on Windows blocks Vim redo #1919

Closed
2 tasks done
jlmakes opened this issue Jun 9, 2017 · 3 comments
Closed
2 tasks done

Refresh hotkey (Ctrl + R) on Windows blocks Vim redo #1919

jlmakes opened this issue Jun 9, 2017 · 3 comments

Comments

@jlmakes
Copy link

jlmakes commented Jun 9, 2017

  • I am on the latest Hyper.app version
  • I have searched the issues of this repo and believe that this is not a duplicate
  • OS version and name: Windows 10 Pro N 10.0.15063
  • Hyper.app version: 1.3.3
  • The issue is reproducible in vanilla Hyper.app: Yes.

Issue

OSX distinguishes between Ctrl and Cmd, but Windows tends to use Ctrl for both scenarios.

In this instance, the Cmd + R refresh hotkey in OSX Hyper, becomes Ctrl + R in Windows Hyper—which takes precedence over the Vim redo command (Ctrl + R on both platforms).

The ability to change the Hyper hotkeys may be a large feature request, so perhaps just changing the Refresh hotkey on windows to Shift + R? I'm not sure what the solution is, but I didn't see this issue brought up and I want raise awareness for fellow developers using Windows (with new Linux subsystem).

@chabou
Copy link
Contributor

chabou commented Jun 9, 2017

The ability to change the Hyper hotkeys has been implemented here #1876
And will be shipped in next release 🎉

Default Windows hotkey will be ctrl+shift+R for Refresh

@jlmakes
Copy link
Author

jlmakes commented Jun 9, 2017

My dreams....... 😢 .....are all..... 😭 ....coming true!

@jlmakes jlmakes closed this as completed Jun 9, 2017
@ppot
Copy link
Contributor

ppot commented Jun 10, 2017

Thanks ❤️ Glad to made your dreams coming true!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants