-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Help with 256 color support on Windows #1968
Comments
Another issue with |
Windows Command Prompt does not support 256 colors 😢 You will need to use a different terminal, like Git For Windows or Msys2 to get 256 color support, and then point hyper.js to their respective executable. |
I thought they supported 24-bit already? https://blogs.msdn.microsoft.com/commandline/2016/09/22/24-bit-color-in-the-windows-console/ |
I think Windows 10 might have support, but not before that. |
Windows 10 does support 256 colors as of TH2, see here When running AnsiColors256.ans via |
@tdurand can you confirm me that you are on Windows? |
Yes, i'm on Windows 10 using WSL with Ubuntu. And the color works well if you use the powershell terminal, so I'm pretty sure it's an issue of hyper. |
Yes, an issue with Hyper (but only on Windows, from my testing). |
Even worse here: Related? #2327 |
any movement on this issue? |
I did a lot and research, testing. It seems it is not a Hyper issue. It is a node-pty issue because of a limitation in the way they interact with processes on Windows. So basically it seems to be still a Windows limitation. You can even confirm this because the integrated shell in vs code has exactly the same issue, and they even use winpty instead of node-pty. |
I am guessing as well it's not necessarily a Hyper issue since it occurs in VSCode as well as ConEmu. I am wondering though how Git Bash by itself or PuTTY does it. I can open Vim locally or when I ssh into a server with no issues. If I run Git Bash in Hyper though, I get the color issues. |
ConEmu supports 256 and true color. Needs a bit of config. https://conemu.github.io/en/Xterm256Colors.html It works via a hook dll that monitors direct calls to write to the console, processing escape codes etc. There's also quite a lot of special case code, including detection of the vim process and powershell. https://github.com/Maximus5/ConEmu/blob/master/src/ConEmuHk/hkConsoleOutput.cpp |
Any news? |
I would appreciate an update on this! Really harming my otherwise fantastic Hyper experience on Windows! Not seeing this issue in Hyper on Ubuntu (VMware). I am using the hyper-solarized-dark-highcontrast theme to make it slightly less worse. |
This is a windows issue @florisvaneck, not much we can do. |
That's xtermjs/xterm.js#484 |
@Stanzilla this is not actually xtermjs/xterm.js#484, that's for truecolor (16 million) color support. 256 color support in Windows is due to winpty: microsoft/vscode#45693 |
Has this been resolved? |
@dvf, nope the issue is still repro |
repro again on windows 10 build 1803 with hyper 2.1.0-canary2 |
Any news? |
This is related news: microsoft/terminal#57 |
More specifically for hyper: microsoft/node-pty#216 |
Better 30 years late than never :-) |
@printempw I'm working on microsoft/node-pty#216 which is expected to fix this, ETA is still a while off though. |
This can be marked as fixed when Hyper adopts node-pty@0.8.0 https://github.com/Microsoft/node-pty/releases/tag/0.8.0. To be clear, it will not work for < Windows 10 1809 and non-WSL may or may not work. |
Thank you very much for hinting. |
That's not a solution for hyper though. Anyway thanks for pointing out a nice alternative. |
This was now done in #3329, so I suppose the issue should be fixed? |
I'll give it a try. I've been putting off some updates for a few days due to some important work. I'll inform you later, thanks :) |
Thanks for the update. Going through now and attempting to apply the 1809 update manually using the tool at microsoft.com. I had assumed windows update was automatically pushing the October update by this point but was mistaken. Trying now. |
FYI there are several issues in Windows 1809 and I moved the default minimum version in node-pty to what is the current fast ring Windows Insiders build, so you should get this in windows 1903. |
So we have to wait a lil bit more... |
It still doesn't work with msys2 on the latest version, mintty with msys2 works fine. |
Issue
Hi,
I would like to be able to use full 256color in Hyper. Setting the env variable TERM to xterm-256color displays colors perfectly.. but it breaks the functionality of the "clear" command. Is there some other way I can accomplish displaying the colors properly while retaining functionality of clear?
The text was updated successfully, but these errors were encountered: