Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Block plugin installation if compatibility is not stated #2633

Open
Stanzilla opened this issue Jan 23, 2018 · 3 comments
Open

[v2] Block plugin installation if compatibility is not stated #2633

Stanzilla opened this issue Jan 23, 2018 · 3 comments
Labels
❣️ Priority: High Issue is of High priority ⏱ Status: Planned The core team is planning to work on this feature
Milestone

Comments

@Stanzilla
Copy link
Contributor

Many plugins will break with the release of v2, to prevent users from suffering from incompatible plugins and their errors/slowdowns, we should block installation/loading if they do not specify a certain tag in their package.json file. That tag could be something like

requiresHyperVersion: >2,

Discuss!

@timothyis
Copy link
Contributor

Hmm, this is interesting. cc @chabou. We discussed before about having better plugin management for versions.

@Stanzilla Stanzilla mentioned this issue Jan 23, 2018
8 tasks
@chabou chabou added this to the 2.0.0 milestone Feb 3, 2018
@chabou
Copy link
Contributor

chabou commented Mar 4, 2018

@timothyis @albinekb @Stanzilla If we want to use engines mechanism, we need to inject hyper version in process.version.
Easy for application but we need to inject it too when running embedded yarn. Here: https://github.com/zeit/hyper/blob/bf2d6ea8555e3a4e40e4c8df34cbe1963282d1fd/app/plugins/install.js#L19-L37

I think that the only solution is to use -r option when launching electron as node, to require a module that will inject version.

We need to check this field when requiring plugins too with some semver comparison.

@Stanzilla
Copy link
Contributor Author

Sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❣️ Priority: High Issue is of High priority ⏱ Status: Planned The core team is planning to work on this feature
Projects
None yet
Development

No branches or pull requests

3 participants