Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Programming Ligatures, Customize Installation, Path Detection #2920

Closed
boxsnake opened this issue Apr 24, 2018 · 9 comments
Closed

Programming Ligatures, Customize Installation, Path Detection #2920

boxsnake opened this issue Apr 24, 2018 · 9 comments
Labels
🎨 Type: Enhancement Issue or PR is an enhancement request/proposal for Hyper

Comments

@boxsnake
Copy link

Env:

  • Win 1703 ver 15063.966
  • MSYS2-64
  • zsh
  • Hyper 2.0.0 stable

Feature Requests:

  • First, programming ligatures. (Fira Code ligatures not showing #914) The solutions here do not work for me. I am using Fira Code.
    • Something look weird here:
      image
  • Second, when I install Hyper.app, may I customize where to install, and where global/local plugins installed? I do not want the programs and plugins to take my space from driver C:\
  • Third, I found there is a path detection every time when the app starts. However, if the app didn't found its path in PATH, it will add one. I prefer to make an %BNP_HYPER% env var, then add %BNP_HYPER% to %PATH% to make %PATH% more readable. In this case, the Hyper.app will still add a new line. E.g.
    image
@timothyis
Copy link
Contributor

Hi! Thanks for submitting this issue.

The first request is upstream and down to xterm.js support ligatures, of which it already has an open issues: xtermjs/xterm.js#958

The second is a good idea, although I don't know how it would work with Electron.

The third, I'm sure we had an issue for this but I can't find it 🤔

@timothyis timothyis added the 🎨 Type: Enhancement Issue or PR is an enhancement request/proposal for Hyper label Apr 24, 2018
@timothyis timothyis changed the title Features requests: Programming Ligatures, Customize Installation, Path Detection Programming Ligatures, Customize Installation, Path Detection Apr 24, 2018
@RangerMauve
Copy link

Regarding ligatures, there's now an xterm plugin that adds support for them.

Would it be possible to include this plugin? Aternately, would you mind giving me some pointers on how I could make a hyper plugin which would add this?

@tolbertam
Copy link

@RangerMauve I experimented with incorporating xterm-addon-ligatures and it does look like getting it to work was pretty easy! I just followed the instructions in the repository and it seemed to just work.

The module requires xterm 3.6.0 (which looks like #3178 will take care of?), and hyper currently depends on 3.4.1. I tried xterm 3.6.0 with hyper and it seems to work! Although the terminal window doesn't fully expand initially (may just be a compatibility issue)

hyperligature

The changes for this: tolbertam/hyper@04f1b71 . Although I suspect these aren't complete, as there should probably be a way of disabling font ligatures, this is a pretty good start.

@tolbertam
Copy link

tolbertam commented Aug 25, 2018

Maybe this could be something made available as a plugin instead of being baked in? I can look into that if that makes sense. EDIT: Ah I see, that doing this as a plugin was suggested, so I'm 👍 on that and will look into it.

@tolbertam
Copy link

I was able to make this work as a plugin, but note that it doesn't work with the currently released version of hyper (it will work after xterm is updated to 3.6.0 via #3178).

Plugin can be found here: https://github.com/tolbertam/hyper-font-ligatures and installed via hyper i hyper-font-ligatures.

@RangerMauve
Copy link

That's so awesome @tolbertam!

@boxsnake
Copy link
Author

boxsnake commented Oct 10, 2019

@timothyis
If you are using electron-builder, for nsis installation, to set the installation path, you can set this:

{
    ...,
    "build": {
        "nsis": {
            "oneClick": false,
            "allowToChangeInstallationDirectory": true
        }
    }
}

For plugins installation paths, I think there should be configuration items in hyper.js. When the packages are installed, check hyper.js config first.

@Stanzilla
Copy link
Collaborator

Can you please split up your issue for the three parts? Ligatures are now supported in the canary CI builds

@boxsnake
Copy link
Author

Can you please split up your issue for the three parts? Ligatures are now supported in the canary CI builds

I just separate the second one, since the first is in canary CI, and the third has an existing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 Type: Enhancement Issue or PR is an enhancement request/proposal for Hyper
Projects
None yet
Development

No branches or pull requests

5 participants