-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Programming Ligatures, Customize Installation, Path Detection #2920
Comments
Hi! Thanks for submitting this issue. The first request is upstream and down to xterm.js support ligatures, of which it already has an open issues: xtermjs/xterm.js#958 The second is a good idea, although I don't know how it would work with Electron. The third, I'm sure we had an issue for this but I can't find it 🤔 |
Regarding ligatures, there's now an xterm plugin that adds support for them. Would it be possible to include this plugin? Aternately, would you mind giving me some pointers on how I could make a hyper plugin which would add this? |
@RangerMauve I experimented with incorporating The module requires xterm 3.6.0 (which looks like #3178 will take care of?), and hyper currently depends on 3.4.1. I tried xterm 3.6.0 with hyper and it seems to work! Although the terminal window doesn't fully expand initially (may just be a compatibility issue) The changes for this: tolbertam/hyper@04f1b71 . Although I suspect these aren't complete, as there should probably be a way of disabling font ligatures, this is a pretty good start. |
Maybe this could be something made available as a plugin instead of being baked in? I can look into that if that makes sense. EDIT: Ah I see, that doing this as a plugin was suggested, so I'm 👍 on that and will look into it. |
I was able to make this work as a plugin, but note that it doesn't work with the currently released version of hyper (it will work after xterm is updated to 3.6.0 via #3178). Plugin can be found here: https://github.com/tolbertam/hyper-font-ligatures and installed via |
That's so awesome @tolbertam! |
@timothyis {
...,
"build": {
"nsis": {
"oneClick": false,
"allowToChangeInstallationDirectory": true
}
}
} For plugins installation paths, I think there should be configuration items in |
Can you please split up your issue for the three parts? Ligatures are now supported in the canary CI builds |
I just separate the second one, since the first is in canary CI, and the third has an existing issue. |
Env:
Feature Requests:
C:\
PATH
, it will add one. I prefer to make an%BNP_HYPER%
env var, then add%BNP_HYPER%
to%PATH%
to make%PATH%
more readable. In this case, the Hyper.app will still add a new line. E.g.The text was updated successfully, but these errors were encountered: